Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom showerror handling #19

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

mmcgr
Copy link
Contributor

@mmcgr mmcgr commented Nov 15, 2024

Add the ability to accept a custom showerror when summarising current exceptions.

Copy link
Collaborator

@msagarpatel msagarpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel safer already 😌 Thank you, @mmcgr!

src/exception_summary.jl Show resolved Hide resolved
src/exception_summary.jl Show resolved Hide resolved
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.80%. Comparing base (f9f8410) to head (a97f6b9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   96.80%   96.80%           
=======================================
  Files           3        3           
  Lines         125      125           
=======================================
  Hits          121      121           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@charnik charnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @mmcgr !

@msagarpatel msagarpatel merged commit 2704436 into JuliaServices:master Nov 18, 2024
6 checks passed
Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

genius ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants