Prepare next release #17

hsonne · 2024-01-06T12:13:05Z

This change is

and use stats::setNames() to shorten by 1 line

(lci_methods -> methods)

so that the post-processing can remain

Start adding support for json files as input

TODO: check if I can use this more general function to simplify or shorten the existing approach.

Keep the name of the original list elements in a column if there was more than one element from which flattened data frames are joined

Add json import

(by default)

Add expand_to_all_key_combinations()

mrustl · 2024-03-21T08:41:37Z

DESCRIPTION line 3 at r1 (raw file):

Package: kwb.umberto
Title: R package supporting UMERTO LCA at KWB
Version: 0.2.0.9000

Please bump version number before moving to "master". In addition also update NEWS.md if not already done!

mrustl · 2024-03-21T10:19:04Z

R/import_json_files_to_excel.R line 15 at r1 (raw file):

#'   possible combinations of values in these key columns are then given in each
#'   sheet even though there are no values for these key value combinations.
#'   Default: \code{c("indicator", "process", "place", "exchange")}

does not fit with number of values for "expand_keys" in function

mrustl · 2024-03-21T10:20:22Z

R/import_rawdata_json.R line 5 at r1 (raw file):

  #remotes::install_github("kwb-r/kwb.umberto@dev")
  
  json_dir <- "~/../Downloads/S/support/fabian/R-Umberto/Umberto11"

Add this part as new "vignette" for new UMBERTO version

mrustl

Reviewed 14 of 16 files at r1, all commit messages.
Reviewable status: 14 of 16 files reviewed, 3 unresolved discussions (waiting on @hsonne)

mrustl

minor comments for improvement ;-)

Reviewable status: 14 of 16 files reviewed, 3 unresolved discussions (waiting on @hsonne)

mrustl

only minor comments for improvement ;-)

Reviewed 2 of 16 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @hsonne)

mrustl · 2024-03-21T10:23:56Z

Add new vignette for new UMBERTO import
Bump version of R package for release and update NEWS.md

hsonne and others added 30 commits September 5, 2023 18:42

Indicate development version

6ae75cc

Improve indentation

0b7b58c

Use selectColumns(), add argument "method_col"

fb57971

Consider column name passed as argument

3642a7b

Name list elements according to method_col

5b7c60a

and use stats::setNames() to shorten by 1 line

Use lapply() and simplify variable name

ca07fe1

(lci_methods -> methods)

Start adding support for json files as input

3b44e1d

Fix issues reported by R CMD check

9ee4436

Provide the old format

825470c

so that the post-processing can remain

Document argument "method_col"

0cb62e2

Document and export import_rawdata_json()

cdfd048

Fix error in documentation

9c5b3ff

Use arrange() instead of deprecated arrange_()

712b31d

Merge pull request #15 from KWB-R/add-json-import

254df97

Start adding support for json files as input

Remove unused function flatten_all()

80e536e

Move general functions to utils.R

b271049

Remove unused function flatten()

c6cdb8a

Move to_tables() and related to its own file

6b4ba96

Move functions to utils.R, reorder by name

69a7b93

Remove unused flatten_list_of_unnamed_elements()

0f24d9e

Move two functions to helpers.R, reorder funcs

e9e98e6

Add general flatten() function, try to use it

9ad4d6e

TODO: check if I can use this more general function to simplify or shorten the existing approach.

Merge branch 'dev' into add-json-import

1e2ab51

Document better what could be improved

41be702

Add argument "sep", pass args to recursive call

17b49d0

Handle different cases when row-binding

6df4e45

Keep the name of the original list elements in a column if there was more than one element from which flattened data frames are joined

Use flatten(), compare with original results

7bf5e85

Remove old processing and code for comparison

8f0f012

Try to use new flatten() in to_product()

b914b8e

Use flatten() on a higher level, check identity

d00f819

hsonne and others added 22 commits January 5, 2024 16:57

Improve formatting

9705817

Add split_by_columns()

95d9783

Rename "result" to "result_tables"

7b188ba

Fix bug in pipe

7f1bcc3

Load files from Lea

ff9a9aa

Update Rd file

bfe43cd

Add import_json_files_to_excel()

1ed8719

Omit intermediate variable "base_name"

1977a5e

Merge pull request #16 from KWB-R/add-json-import

8a8f8a9

Add json import

Clean stop_on_differing_names()

95bc422

Create Excel file within input directory

13db857

(by default)

Import kwb.utils::stopFormatted()

604a94b

Add argument "overwrite"

4dab708

Name sheets "m01", "m02", ...

3731059

Add argument "expand" for same rows in sheets

0dad4c2

Reimplement the "expanding" of sheets

2dd80ab

Update Rd file

90921df

Add test call

105d70e

Fix 🐛 in expand_to_all_key_combinations()

14fff20

Add comment with installation command

1856d46

Merge pull request #18 from KWB-R/expand

cb61911

Add expand_to_all_key_combinations()

Install from "dev" after merging "expand"

9d7182d

hsonne requested a review from mrustl March 18, 2024 18:19

mrustl reviewed Mar 21, 2024

View reviewed changes

mrustl approved these changes Mar 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare next release #17

Prepare next release #17

hsonne commented Jan 6, 2024 •

edited by mrustl

Loading

mrustl commented Mar 21, 2024

mrustl commented Mar 21, 2024

mrustl commented Mar 21, 2024

mrustl left a comment

mrustl left a comment

mrustl left a comment

mrustl commented Mar 21, 2024

Prepare next release #17

Are you sure you want to change the base?

Prepare next release #17

Conversation

hsonne commented Jan 6, 2024 • edited by mrustl Loading

mrustl commented Mar 21, 2024

mrustl commented Mar 21, 2024

mrustl commented Mar 21, 2024

mrustl left a comment

Choose a reason for hiding this comment

mrustl left a comment

Choose a reason for hiding this comment

mrustl left a comment

Choose a reason for hiding this comment

mrustl commented Mar 21, 2024

hsonne commented Jan 6, 2024 •

edited by mrustl

Loading