-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the proposal for the new data model. #167
base: main
Are you sure you want to change the base?
Conversation
This was originally posted by @javagl
|
So, I'm actually seriously considering we potentially get rid of the separate filter fields and move to a "super field" that can accept full text searching plus some filtering potential based on any tag with a bit of autocomplete. Effectively, you could have a query like:
Pure text would be an entire full-text and the the tags would be a div elements, represented by the brackets. By typing I can mock something up while I'm on holiday. Stay tuned for more. |
I thought about that as well - similar to searches like in the GitHub PRs, which by default are Some high-level brainstorming thoughts:
(There's still that task on my plate to wrap up that local experiment, where I tried to filter the lists of available filter tags, so that it's not possible to click a filter that causes the list to become empty. From a UX perspective, that's awkward, to say the least. But maybe we should try to focus on the POC, keeping future features in mind, but tracking the ideas around that in other issues) |
Not really substantial progress here. However, one aspect from my first (quoted) comment here was
and in the latest pass, I added this in the metadata JSON as
This is probably preliminary. On the one hand, the question of whether something can be used for filtering is part of the data model (we cannot use these filters for free-text fields ... and they wouldn't make much sense for a So I think that these things could reasonably be part of a "config file" that is independent of the metadata, and that may carry ~"all the stuff that is relevant only for the UI". This file might later also include stuff like color schemes or whatnot. |
These answers are all over the place. Weekend hasn't gone as I had hoped it would so I didn't make as much progress today as I had hoped. Going to spend a bit more time tomorrow evening to wrap up the mockups of the "super-search". I'll also get #168 reviewed fully in the morning. I think those five tags are good for the first pass.
I'd honestly like to avoid this if possible, and that's part of the reason for having the metadata block. I think it's reasonable for the metadata block to provide the relevant information for the UI, including order, descriptive text, and whatever else we need. It doesn't need to support all of this up-front. I realize that is flying awfully close to almost a CMS amount of complexity, but I think that's one of the things that CMS solutions tend to do right more often than not. I see this approach as being particularly advantageous because it would allow us to have a single code-base.
This is a big question, and one I do think we need to answer. While
This is really easily overthought, and I'd suggest we just do what we're currently doing. Tag categories are
The user would get results that have either gltf or fbx input support, written in C++. |
Also, another idea for sorting out the search and filtering query language is to see what we can do with something like Elasticlunr, or even flexsearch which we are using now. Abstracting something out via the UI shouldn't be too difficult. |
As discussed earlier today, here is the proposal for the new data model, brought over from the gist.