Skip to content

Commit

Permalink
ci: use same postgres as production
Browse files Browse the repository at this point in the history
  • Loading branch information
@3v0k4
3v0k4 committed Dec 19, 2023
1 parent 5f4b6bd commit 1f217df
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
# KNAPSACK_PRO_TEST_SUITE_TOKEN_MINITEST: minitest-token
# KNAPSACK_PRO_TEST_SUITE_TOKEN_SPINACH: spinach-token

- image: cimg/postgres:16.1
- image: cimg/postgres:14.7
environment:
POSTGRES_DB: rails-app-with-knapsack_pro_test
POSTGRES_PASSWORD: password
Expand Down

3 comments on commit 1f217df

@ArturT
Copy link
Member

@ArturT ArturT commented on 1f217df Dec 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3v0k4 I think it does not matter because postgres version is relevant to the Rails app itself. Not how Knapsack Pro works. We could use the latest postgres here.

@3v0k4
Copy link
Contributor Author

@3v0k4 3v0k4 commented on 1f217df Dec 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArturT true, but for the time being I'd keep it the same since it doesn't really matter

@ArturT
Copy link
Member

@ArturT ArturT commented on 1f217df Dec 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.

Please sign in to comment.