Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gems which are not part of Ruby 3.4 to Gemfile to make knapsack_pro work on Ruby 3.4 #70

Closed
wants to merge 13 commits into from

Conversation

ArturT
Copy link
Member

@ArturT ArturT commented Oct 29, 2024

Add gems which are not part of Ruby 3.4 to Gemfile to make knapsack_pro work on Ruby 3.4

/.rvm/gems/ruby-3.4.0-preview2/gems/activesupport-6.1.7.10/lib/active_support/dependencies.rb:299: warning: mutex_m was loaded from the standard library, but is not part of the default gems starting from Ruby 3.4.0.
You can add mutex_m to your Gemfile or gemspec to silence this warning.

etc
@ArturT
Copy link
Member Author

ArturT commented Oct 29, 2024

After adjusting this rails app to make it work with Ruby 3.4-preview2, the CI builds on Ruby 3.3.1 fail with the error:

Downloading net-smtp-0.5.0 revealed dependencies not in the API or the lockfile
(net-protocol (>= 0)).
Running bundle update net-smtp should fix the problem.

But the rails app and tests with knapsack_pro work find locally.

I guess we need to use Ruby 3.4 on CI but there is no docker image available yet.
We have to wait until Ruby 3.4 is officially released.
If it does not help then the issue might be related to this one:

Other than that we might want to update Rails 6 to 7 because now we have odd hacks in Gemfile:

# Fix for Ruby 3.1.x
# https://stackoverflow.com/a/70500221/905697
# https://github.com/mikel/mail/pull/1439
# This can be removed after upgrade to Rails 7.x
gem 'net-smtp', require: false
gem 'net-imap', require: false
gem 'net-pop', require: false

@ArturT ArturT closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant