Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nova/big nat #185

Merged
merged 11 commits into from
Dec 21, 2023
Merged

Nova/big nat #185

merged 11 commits into from
Dec 21, 2023

Conversation

KiriosK
Copy link
Collaborator

@KiriosK KiriosK commented Dec 18, 2023

No description provided.

@KiriosK KiriosK changed the base branch from master to nova/cycle_of_curves December 18, 2023 09:03
@KiriosK KiriosK changed the base branch from nova/cycle_of_curves to master December 19, 2023 00:25
@KiriosK KiriosK self-assigned this Dec 20, 2023
@KiriosK KiriosK marked this pull request as ready for review December 20, 2023 10:07
@KiriosK KiriosK changed the title [WIP] Nova/big nat Nova/big nat Dec 20, 2023
@KiriosK KiriosK requested a review from ashWhiteHat December 20, 2023 10:08
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (ff1e428) 77.69% compared to head (146ba37) 79.40%.
Report is 1 commits behind head on master.

Files Patch % Lines
nova/src/gadget/big_nat.rs 97.80% 6 Missing ⚠️
zkstd/src/circuit/gadget/field.rs 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   77.69%   79.40%   +1.71%     
==========================================
  Files          68       68              
  Lines        4488     4745     +257     
==========================================
+ Hits         3487     3768     +281     
+ Misses       1001      977      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashWhiteHat ashWhiteHat merged commit 6d2df31 into master Dec 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants