Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nova/pallet #186

Merged
merged 11 commits into from
Dec 22, 2023
Merged

Nova/pallet #186

merged 11 commits into from
Dec 22, 2023

Conversation

KiriosK
Copy link
Collaborator

@KiriosK KiriosK commented Dec 21, 2023

No description provided.

@KiriosK KiriosK self-assigned this Dec 21, 2023
@KiriosK KiriosK changed the title [WIP] Nova/pallet Nova/pallet Dec 21, 2023
@KiriosK KiriosK marked this pull request as ready for review December 21, 2023 08:39
@KiriosK KiriosK requested a review from ashWhiteHat December 21, 2023 08:39
@KiriosK KiriosK marked this pull request as draft December 22, 2023 01:37
@KiriosK KiriosK marked this pull request as ready for review December 22, 2023 05:24
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (146ba37) 79.40% compared to head (0b3ab98) 79.41%.
Report is 2 commits behind head on master.

Files Patch % Lines
nova_pallet/src/lib.rs 54.54% 5 Missing ⚠️
bn254/src/ff_compat.rs 0.00% 4 Missing ⚠️
bn254/benches/bn_254_field.rs 0.00% 3 Missing ⚠️
groth16/src/poly.rs 0.00% 2 Missing ⚠️
bn254/src/gt.rs 0.00% 1 Missing ⚠️
zkstd/src/r1cs.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   79.40%   79.41%           
=======================================
  Files          68       69    +1     
  Lines        4745     4771   +26     
=======================================
+ Hits         3768     3789   +21     
- Misses        977      982    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashWhiteHat ashWhiteHat merged commit 019b895 into master Dec 22, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants