Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/gas fee estimator docs #293

Closed
wants to merge 14 commits into from
Closed

Add/gas fee estimator docs #293

wants to merge 14 commits into from

Conversation

harsenyan3
Copy link
Collaborator

@harsenyan3
Added documentation for Gas Fee Estimator RPC methods
9e4b446 
Added docs for:
1. start_gas_fee_estimator
2. stop_gas_fee_estimator
3. get_eth_estimated_fee_per_gas
@harsenyan3 harsenyan3 mentioned this pull request Jul 18, 2024
Closed
@gcharang gcharang changed the base branch from main to dev July 18, 2024 11:07
smk762
smk762 reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the latest release, I am unable to get a response from these methods.

  • get_eth_estimated_fee_per_gas -> Gas fee estimation not supported for this coin
  • start_gas_fee_estimator -> NoSuchMethod
  • stop_gas_fee_estimator -> NoSuchMethod

cc: @dimxy

@smk762 smk762 requested a review from dimxy September 9, 2024 06:14
@dimxy
Copy link

dimxy commented Sep 9, 2024 •
edited
Loading

  • start_gas_fee_estimator

Sorry, I renamed those rpcs to

start_eth_fee_estimator
stop_eth_fee_estimator

(btw I have a bug when the eth fee estimator does not start if the new 'enable_eth_with_tokens' rpc was used to enable coins, it starts okay only if the old 'enable' rpc used. Fixed in my current work for access lists #2170)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

Preview for merge commit: dde5272, available on cloudflare at: https://f751e334.komodo-docs.pages.dev/en/docs/

@smk762 smk762 mentioned this pull request Sep 13, 2024
Open
@smk762 smk762 added P1 Important task which needs to be completed soon KDF 2.2.0-beta awaiting review and removed v2.1.0-beta-changelog labels Sep 13, 2024
@smk762 smk762 marked this pull request as draft September 13, 2024 08:39
@smk762
Copy link
Contributor

smk762 commented Sep 13, 2024

Set to "draft" until KomodoPlatform/komodo-defi-framework#2170 (comment) is resolved

@github-actions GitHub Actions
Copy link

Preview for merge commit: 3b38993, available on cloudflare at: https://e8429f1b.komodo-docs.pages.dev/en/docs/

@dimxy
Copy link

dimxy commented Oct 21, 2024

Plz be aware that gas fee estimator rpcs

start_eth_fee_estimator
stop_eth_fee_estimator

will be removed in this PR 2172 as it will be managed by the new streaming API rpc "fee_estimator::enable"

@smk762 smk762 added doc needs update and removed P1 Important task which needs to be completed soon awaiting review labels Oct 28, 2024
@smk762
Copy link
Contributor

smk762 commented Nov 5, 2024

Closing in favor of #293

@smk762 smk762 closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smk762 smk762 smk762 left review comments

@AndrewDelaney AndrewDelaney Awaiting requested review from AndrewDelaney

@ShantanuSharma9873 ShantanuSharma9873 Awaiting requested review from ShantanuSharma9873

@dimxy dimxy Awaiting requested review from dimxy

Assignees
No one assigned
Labels
doc needs update KDF 2.2.0-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harsenyan3 @dimxy @smk762 @gcharang