feat(dataplane): move DataPlane ports validation to ValidationAdmissionPolicy and ValidationAdmissionPolicyBinding #1007
+513
−260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
dataplane-ports-validation-migrate-to-validation-policy
branch
3 times, most recently
from
4f5da6f to
22cffd6
Compare
czeslavo
previously approved these changes
Jan 16, 2025
pmalek
force-pushed
the
dataplane-ports-validation-migrate-to-validation-policy
branch
2 times, most recently
from
e112d0a to
b03db6a
Compare
I agree, as agreed on slack I added tests by extending the crd validation tests in b03db6a PTAL. |
4 tasks
pmalek
force-pushed
the
dataplane-ports-validation-migrate-to-validation-policy
branch
4 times, most recently
from
f1333b8 to
e92ea86
Compare
|
@czeslavo This is ready for review now. Feel free to take a look and comment. |
czeslavo
previously approved these changes
Jan 17, 2025
config/default/validation_policies/dataplane_validation_policies.yaml
Outdated
Show resolved
Hide resolved
pmalek
force-pushed
the
dataplane-ports-validation-migrate-to-validation-policy
branch
from
8afcb73 to
4ffde37
Compare
pmalek
force-pushed
the
dataplane-ports-validation-migrate-to-validation-policy
branch
5 times, most recently
from
41ebe42 to
886290f
Compare
…onPolicy and ValidationAdmissionPolicyBinding
…olicies.yaml to config/default/validation_policies/dataplane_validating_policies.yaml
pmalek
force-pushed
the
dataplane-ports-validation-migrate-to-validation-policy
branch
from
341246f to
8c3adfb
Compare
czeslavo
approved these changes
Jan 17, 2025
pmalek
deleted the
dataplane-ports-validation-migrate-to-validation-policy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes
Part of #949.
This will get an accompanying charts PR where
ValidationAdmissionPolicy andValidationAdmissionPolicyBinding` are added there.This all sets the max items on the
DataPlaneServicePortarray to 4 to potentially cut the added validations cost down.An initial attempt on this was to add CEL rules on the CRD but API server was complaining about the cost of these. With
ValidationAdmissionPolicyrules it was possible.Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes