Skip to content

Commit

Permalink
Merge pull request #463 from adeschen/main
Browse files Browse the repository at this point in the history
Update test to remove TODO
  • Loading branch information
adeschen authored Aug 20, 2023
2 parents dc6bbfb + 86dc778 commit 52702e0
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 4 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Description: This package implements specialized algorithms that enable
following publication: Belleau, P et al. Genetic Ancestry Inference from
Cancer-Derived Molecular Data across Genomic and Transcriptomic
Platforms. Cancer Res 1 January 2023; 83 (1): 49–58.
Version: 0.99.7
Version: 0.99.8
Authors@R: c(person("Pascal", "Belleau", email="[email protected]",
role=c("cre", "aut"), comment = c(ORCID = "0000-0002-0802-1071")),
person("Astrid", "Deschênes", email="[email protected]",
Expand Down
8 changes: 8 additions & 0 deletions inst/NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
CHANGES IN VERSION 0.99.8
------------------------

SIGNIFICANT USER-VISIBLE CHANGES

o Some examples have been updated in the documentation.


CHANGES IN VERSION 0.99.7
------------------------

Expand Down
7 changes: 4 additions & 3 deletions tests/testthat/test-tools_internal.R
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ test_that("validateGDSClass() must return expected results when all input are va

test_that("validateGDSClass() must return error when input is not valid", {

expected <- "The \'todo_01\' must be an object of class \'gds.class\'."
expected <- "The \'tudo_01\' must be an object of class \'gds.class\'."

expect_error(RAIDS:::validateGDSClass(gds="toto.gds", name="todo_01"),
expect_error(RAIDS:::validateGDSClass(gds="toto.gds", name="tudo_01"),
expected, fixed=TRUE)
})

Expand Down Expand Up @@ -136,7 +136,8 @@ context("validatePositiveIntegerVector() results")

test_that("validatePositiveIntegerVector() must return expected results when all input are valid", {

result1 <- RAIDS:::validatePositiveIntegerVector(value=c(1,2,3), name="parameter_01")
result1 <- RAIDS:::validatePositiveIntegerVector(value=c(1,2,3),
name="parameter_01")

expect_identical(result1, 0L)
})
Expand Down

0 comments on commit 52702e0

Please sign in to comment.