Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: reset password does not validate email #315

Merged
merged 3 commits into from
Oct 20, 2024
Merged

Bugfix: reset password does not validate email #315

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0584a89
make it easier to change users in a team
Gustavo-SF Oct 20, 2024
224db9e
just return email when doing a reset password
Gustavo-SF Oct 20, 2024
da9db5b
Merge branch 'dev' into bugfix/reset-password-does-not-validate-email
Gustavo-SF Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions portal/portal/users/adapters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ def is_open_for_signup(self, request: HttpRequest):

def clean_email(self, email):
email = super().clean_email(email)
request = getattr(self, "request", None)

# Skip unique email check if it's a password reset request
if request and request.path == reverse("account_reset_password"):
return email

if email and app_settings.UNIQUE_EMAIL:
if EmailAddress.objects.filter(email=email).exists():
raise ValidationError(
Expand Down
Loading