Modify column Name content from username to first_name + last_name. A… #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lso removes column Slack with slackid from the students list.
Gustavo-SF
reviewed
Nov 19, 2024
Gustavo-SF
reviewed
Nov 19, 2024
There was a problem hiding this comment.
This needs to be removed since this isn't a package.
Gustavo-SF
reviewed
Nov 19, 2024
There was a problem hiding this comment.
This also isn't a package yet, so an init shouldn't go here.
Gustavo-SF
reviewed
Nov 19, 2024
| @@ -140,7 +140,8 @@ class StudentUnitDetailView(StudentViewsMixin, BaseUnitDetailView): | |||
|
|
|||
| class InstructorUserListView(InstructorViewsMixin, ListView): | |||
| model = get_user_model() | |||
| queryset = get_user_model().objects.filter(is_student=True, failed_or_dropped=False) | |||
| queryset = model.objects.filter(is_student=True, failed_or_dropped=False) | |||
| #queryset = get_user_model().objects.filter(is_student=True, failed_or_dropped=False) | |||
There was a problem hiding this comment.
It is ok to make this change, but please don't leave commented code 🙏 You can remove the second line.
| <th scope="col" rowspan="2">Slack</th> | ||
| {% endcomment %} |
There was a problem hiding this comment.
We can simply remove it. No need to comment lines of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lso removes column Slack with slackid from the students list.
Changes
Issue(s)