Merge pull request #173 from LambdaTest/stage

Release 4.0.11
LambdaTest · Nov 25, 2024 · 8bc94c4 · 8bc94c4
2 parents 95a90c3 + b037475
commit 8bc94c4
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 7 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@lambdatest/smartui-cli",
-  "version": "4.0.10",
+  "version": "4.0.11",
   "description": "A command line interface (CLI) to run SmartUI tests on LambdaTest",
   "files": [
     "dist/**/*"

diff --git a/src/lib/processSnapshot.ts b/src/lib/processSnapshot.ts
@@ -301,6 +301,31 @@ export default async function processSnapshot(snapshot: Snapshot, ctx: Context):
                 throw new Error(`for snapshot ${snapshot.name} viewport ${viewportString}, multiple elements found for selector ${processedOptions.element}`);
             }
         } else if (selectors.length) {
+            let height = 0;
+            height = await page.evaluate(() => {
+                const DEFAULT_HEIGHT = 16384;
+                const body = document.body;
+                const html = document.documentElement;
+                if (!body || !html) {
+                    ctx.log.debug('Document body or html element is missing, using default height');
+                    return DEFAULT_HEIGHT;
+                }
+                const measurements = [
+                    body?.scrollHeight || 0,
+                    body?.offsetHeight || 0,
+                    html?.clientHeight || 0,
+                    html?.scrollHeight || 0,
+                    html?.offsetHeight || 0
+                ];
+                const allMeasurementsInvalid = measurements.every(measurement => !measurement);
+                if (allMeasurementsInvalid) {
+                    ctx.log.debug('All height measurements are invalid, using default height');
+                    return DEFAULT_HEIGHT;
+                }
+                return Math.max(...measurements);
+            });
+            ctx.log.debug(`Calculated content height: ${height}`);
+
             let locators: Array<Locator> = [];
             if (!Array.isArray(processedOptions[ignoreOrSelectBoxes][viewportString])) processedOptions[ignoreOrSelectBoxes][viewportString] = []
 
@@ -314,12 +339,23 @@ export default async function processSnapshot(snapshot: Snapshot, ctx: Context):
             }
             for (const locator of locators) {
                 let bb = await locator.boundingBox();
-                if (bb) processedOptions[ignoreOrSelectBoxes][viewportString].push({
-                    left: bb.x,
-                    top: bb.y,
-                    right: bb.x + bb.width,
-                    bottom: bb.y + bb.height
-                });
+                if (bb) {
+                    // Calculate top and bottom from the bounding box properties
+                    const top = bb.y;
+                    const bottom = bb.y + bb.height;
+
+                    // Only push if top and bottom are within the calculated height
+                    if (top <= height && bottom <= height) {
+                        processedOptions[ignoreOrSelectBoxes][viewportString].push({
+                            left: bb.x,
+                            top: top,
+                            right: bb.x + bb.width,
+                            bottom: bottom
+                        });
+                    } else {
+                        ctx.log.debug(`Bounding box for selector skipped due to exceeding height: ${JSON.stringify({ top, bottom, height })}`);
+                    }
+                }
             }
         }
         ctx.log.debug(`Processed options: ${JSON.stringify(processedOptions)}`);