Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load files mentioned in mocha config file #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

load files mentioned in mocha config file #56

wants to merge 1 commit into from

Conversation

VikrantKS
Copy link
Contributor

Issue

#55

Description

This PR will add support to load files mentioned in mocha config file
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested with aurelia
  • Tested with geofire

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@VikrantKS VikrantKS added enhancement New feature or request release:patch Releases patch version labels Jul 25, 2022
@VikrantKS VikrantKS marked this pull request as ready for review July 26, 2022 11:35
VikrantKS
VikrantKS commented Jul 26, 2022
View reviewed changes
packages/mocha-runner/src/mocha-runner.ts
return mocha;
}
async discoverTests(argv: parser.Arguments): Promise<DiscoveryResult> {
const mocha = this.createMochaInstance()
await mocha.loadFilesAsync();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this because I wanted to load pre test file first

@saurabh-prakash saurabh-prakash removed their request for review November 15, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request release:patch Releases patch version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VikrantKS