poc(lld): 🔒 ASAR integrity check #8748
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
|
There as been no activity on this PR for the last 14 days. Please consider closing this PR. |
thesan
force-pushed
the
poc/asar-integrity-check
branch
3 times, most recently
from
47a70f4 to
f9aa1a6
Compare
(Simply by leaving `CSC_IDENTITY_AUTO_DISCOVER` to true)
thesan
force-pushed
the
poc/asar-integrity-check
branch
from
f9aa1a6 to
61991b1
Compare
thesan
force-pushed
the
poc/asar-integrity-check
branch
2 times, most recently
from
9cefe28 to
d04dcbb
Compare
live-github-bot
bot
added
tools
thesan
force-pushed
the
poc/asar-integrity-check
branch
2 times, most recently
from
54de99a to
0f6b1c1
Compare
thesan
force-pushed
the
poc/asar-integrity-check
branch
from
0f6b1c1 to
769be20
Compare
thesan
force-pushed
the
poc/asar-integrity-check
branch
from
769be20 to
bf1098f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
This draft attempts to enable the ASAR integrity check and upgrade electron builder to v25 to enable it on Windows too.
The ASAR integrity check works. However:
tiny-secp256k1doesn't build withelectron@32+on Windows because theNOMINMAXmacro is somehow missing (a similar issue was reported in early Node@22 build: defineNOMINMAXin common.gypi nodejs/node#52794, more info in this post).@electron/[email protected](for unclear reason) so the version was forced to3.7.1(which comes with a patchednode-gyp).electron-app-universal-protocol-clientdoesn't build either so it was temporary removed. It was initially added in chore(LLD): add deeplink support in dev mode #6701 to support deeplink in dev mode.More details in the tech research
🎥 Demo:
On MacOS:
MacASARCheck.mov
On Windows:
WinASARCheck.mp4
❓ Context
🧐 Checklist for the PR Reviewers