Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update Market spec test to handle flacky test on Bitcoin search #8910

Merged
merged 3 commits into from
Jan 17, 2025
Merged

chore: Update Market spec test to handle flacky test on Bitcoin search #8910

merged 3 commits into from
Jan 17, 2025

Conversation

mcayuelas-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Update Market spec test to handle flacky test on Bitcoin search

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested review from a team as code owners January 15, 2025 15:11
@vercel Vercel
Copy link

vercel bot commented Jan 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 9:37am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 9:37am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 9:37am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 9:37am

@mcayuelas-ledger
Copy link
Contributor Author

mcayuelas-ledger commented Jan 15, 2025 •
edited by live-github-bot bot
Loading

@mcayuelas-ledger

Generating screenshots: workflow ended

Jobs status:
❌ - generate-screenshots-linux

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jan 15, 2025
themooneer
themooneer previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcayuelas-ledger
Copy link
Contributor Author

mcayuelas-ledger commented Jan 15, 2025 •
edited by live-github-bot bot
Loading

@mcayuelas-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux

@live-github-bot live-github-bot bot added the screenshots Screenshots have been updated label Jan 16, 2025
@mcayuelas-ledger
Copy link
Contributor Author

mcayuelas-ledger commented Jan 16, 2025 •
edited by live-github-bot bot
Loading

@mcayuelas-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux

@live-github-bot live-github-bot bot removed the screenshots Screenshots have been updated label Jan 17, 2025
themooneer
themooneer approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcayuelas-ledger mcayuelas-ledger merged commit fcfcd4e into develop Jan 17, 2025
40 of 41 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the chore/market-E2E-fix branch January 17, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themooneer themooneer themooneer approved these changes

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger left review comments

Assignees

@mcayuelas-ledger mcayuelas-ledger

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcayuelas-ledger @themooneer @ypolishchuk-ledger