Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticate with docker before running ghcommit action #8919

Merged

Conversation

angusbayley
Copy link
Contributor

@angusbayley angusbayley commented Jan 16, 2025

To fix this issue, this PR adds a docker authentication step prior to calling the ghcommit verified commits action during generate-screenshots.

This PR is tested in this test branch, which has the successful workflow run here 🟢.

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 11:00am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 11:00am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 11:00am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 11:00am

@live-github-bot live-github-bot bot added automation CI/CD stuff and removed tools Has changes in tools labels Jan 16, 2025
@angusbayley angusbayley marked this pull request as ready for review January 16, 2025 16:36
Copy link
Member

@KVNLS KVNLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@angusbayley angusbayley merged commit bbb8961 into develop Jan 17, 2025
34 of 38 checks passed
@angusbayley angusbayley deleted the support/fix-generate-screenshots-docker-rate-limit branch January 17, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants