Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: LIVE-15628 Fix app crashing when selecting EVM accounts #8921

Conversation

adammino-ledger
Copy link
Contributor

@adammino-ledger adammino-ledger commented Jan 16, 2025

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • walletState passed from useAccountActions to decorator

📝 Description

This PR fixes a bug where the walletState that was introduced on the accountActions was not passed from the account screen.

Screen.Recording.2025-01-16.at.10.33.46.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@adammino-ledger adammino-ledger requested a review from a team as a code owner January 16, 2025 10:40
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 10:42am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 10:42am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 10:42am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 10:42am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Jan 16, 2025
Copy link
Member

@KVNLS KVNLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not tested

@adammino-ledger adammino-ledger merged commit 7802de4 into develop Jan 16, 2025
40 of 41 checks passed
@adammino-ledger adammino-ledger deleted the fix/LIVE-15786-pass-missing-wallet-state-to-accountActions branch January 16, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants