7회차 과제 - 구준혁 #5
Open
7회차 과제 - 구준혁 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyw2790
reviewed
May 14, 2024
| return ( | ||
| <Box> | ||
| <p>{body}</p> | ||
| <button onClick={() => {handleDelete(id)}}>삭제</button> | ||
| {complete === false ? <p>{body}</p> : <IsCompleted>{body}</IsCompleted>} |
There was a problem hiding this comment.
app.js/ const handleComplete = (id) => {....} 이 함수안 에서도 이 부분이 있는거같은데 코드가 중복으로 쓰이는거 아닌가요 ?
There was a problem hiding this comment.
app.js의 해당 코드는 complete값을 바꿔주는 코드입니다!
현재 파일의 코드는 complete 값에 따라 다른 컴포넌트로 {body}를 출력하는 코드입니다!
| } | ||
| }); | ||
| setTodoList(new_Todo); | ||
| }; |
There was a problem hiding this comment.
토글 상태를 true->false , false -> true로 바뀌면서 완료했던 버튼이 다시 되돌아오는 것이군요!!
There was a problem hiding this comment.
맞습니다 !! 다만 연산자 활용을 좀 더 잘 했다면 코드를 더 줄일 수 있겠다는 생각이 듭니다!
gugitgugit
commented
May 14, 2024
| } | ||
| }); | ||
| setTodoList(new_Todo); | ||
| }; |
There was a problem hiding this comment.
맞습니다 !! 다만 연산자 활용을 좀 더 잘 했다면 코드를 더 줄일 수 있겠다는 생각이 듭니다!
| return ( | ||
| <Box> | ||
| <p>{body}</p> | ||
| <button onClick={() => {handleDelete(id)}}>삭제</button> | ||
| {complete === false ? <p>{body}</p> : <IsCompleted>{body}</IsCompleted>} |
There was a problem hiding this comment.
app.js의 해당 코드는 complete값을 바꿔주는 코드입니다!
현재 파일의 코드는 complete 값에 따라 다른 컴포넌트로 {body}를 출력하는 코드입니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 내가 개발한 기능
2. 내가 유의 깊게 개발한 부분
handleComplete()메소드를 통해todoList배열의complete값 변경complete값이true일 때,IsComplted컴포넌트로 생성3. 개발하면서 들었던 의문 사항
-> 필드를 추가하지 않고 useState로 가능하지 않을까?