-
-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add Plex authentification #229
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #229 +/- ##
==========================================
- Coverage 71.84% 66.43% -5.42%
==========================================
Files 12 12
Lines 1087 1147 +60
==========================================
- Hits 781 762 -19
- Misses 306 385 +79
Flags with carried forward coverage won't be shown. Click here to find out more.
|
68c5578
to
c6fd846
Compare
c6fd846
to
e4eafc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any thoughts on unit/functional tests?
41500de
to
b9e08ad
Compare
It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks! |
Not really sure what more I can do here, we were discussing testing at one point but I don't really know how I would go about testing this |
Would you be okay with me pushing some commits to handle the testing? |
Absolutely, thanks! |
Co-authored-by: ReenigneArcher <[email protected]>
Co-authored-by: ReenigneArcher <[email protected]>
a2dbcf8
to
05fe7a0
Compare
ed0d4ff
to
e3da810
Compare
e3da810
to
ab60056
Compare
I think unit tests were pretty close, but held up by the following: |
Description
Adds a setting that allows requiring Plex authentication to access the web UI. This is useful especially if the user wants to expose the web UI to the outside world.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.