Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaults: add EnableTiledWindowMargins option #1166

Merged
merged 1 commit into from
Dec 1, 2024
Merged

defaults: add EnableTiledWindowMargins option #1166

merged 1 commit into from
Dec 1, 2024

Conversation

alanviles
Copy link
Contributor

add EnableTiledWindowMargins to WindowManager.nix to enable the ability to control margins with defaults

Enzime
Enzime requested changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the tests?

modules/system/defaults/WindowManager.nix Outdated Show resolved Hide resolved
modules/system/defaults/WindowManager.nix Outdated Show resolved Hide resolved
@Enzime
Copy link
Collaborator

Enzime commented Nov 15, 2024

Can you also squash the commits and change the commit message to defaults: add EnableTiledWindowMargins option?

@alanviles alanviles changed the title Add EnableTiledWindowMargins to WindowManager.nix defaults: add EnableTiledWindowMargins option Nov 15, 2024
@alanviles
Copy link
Contributor Author

Can you update the tests?

tests updated but some fail and some pass

Enzime
Enzime requested changes Nov 15, 2024
View reviewed changes
tests/fixtures/system-defaults-write/activate-user.txt Outdated Show resolved Hide resolved
tests/fixtures/system-defaults-write/activate-user.txt Outdated
@@ -568,4 +572,4 @@ defaults write ~/Library/Preferences/ByHost/com.apple.controlcenter 'Sound' $'<?
<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<integer>24</integer>
</plist>'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did you change on this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think I changed anything

@alanviles
Copy link
Contributor Author

Updated tests but still don't know why tests fail

checking defaults write in /activate-user
Did not find content from /nix/store/s56pkrw56lq8nbrg5qnvar8rp5llk7w9-system-defaults-write/activate-user.txt 
in /nix/store/jsq2218583v4daix6nxw6sz63y43k66v-darwin-system-24.11.20241113.24f0d4a+darwin5/activate-user

Enzime
Enzime approved these changes Dec 1, 2024
View reviewed changes
Copy link
Collaborator

@Enzime Enzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the contribution

@Enzime Enzime merged commit e30a362 into LnL7:master Dec 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enzime Enzime Enzime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanviles @Enzime