fix(aerospace): remove unusable on-window-detected option #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you seen #1208? The changes there work just fine. |
|
Looks like my lack of understanding of TOML is showing! #1208 works for my needs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extraConfig to replace this.
After a deep dive into pkgs.fomat.toml json2toml is incapable of handling the dot in
if.app-id, so it must be added with plain text.Also [on-window-changed] seems to have been replaced by [[on-window-changed]] in the aerospace config spec, so we're better off removing the option I removed.
Tests passing, and my config is working.