Power related options (sleep, wake-on-lan, restart after power failure, ...) #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipBorgesen
commented
Nov 19, 2023
modules/networking/default.nix
Outdated
| @@ -94,6 +95,16 @@ in | |||
| default = []; | |||
| description = lib.mdDoc "The list of search paths used when resolving domain names."; | |||
| }; | |||
|
|
|||
| networking.wakeOnLan = mkOption { | |||
There was a problem hiding this comment.
Name of option and placement inspired by the NixOS option: networking.interfaces.<name>.wakeOnLan.enable
PhilipBorgesen
commented
Nov 19, 2023
modules/networking/default.nix
Outdated
| @@ -117,6 +128,10 @@ in | |||
| ''} | |||
|
|
|||
| ${setNetworkServices} | |||
|
|
|||
| ${optionalString (cfg.wakeOnLan != null) '' | |||
| systemsetup -setWakeOnNetworkAccess '${onOff cfg.wakeOnLan}' &> /dev/null | |||
There was a problem hiding this comment.
The systemsetup stdout and stderr are silenced:
- The changed value is echoed on stdout, e.g.
setwakeonnetworkaccess: On. - An error is reported on stderr, but the command succeeds as reflected by the corresponding get command and System Settings. Example error:
2023-11-18 15:47:54.640 systemsetup[4589:139580] ### Error:-99 File:/AppleInternal/Library/BuildRoots/11aa8fb2-5f4b-11ee-bc7f-926038f30c31/Library/Caches/com.apple.xbs/Sources/Admin/InternetServices.m Line:379
The above observations apply to the new power and power.sleep options as well.
There was a problem hiding this comment.
I see the silencing matches the work done here: #781
PhilipBorgesen
force-pushed
the
power-related-options
branch
from
4b1fd12 to
7a24217
Compare
|
@Enzime I hope you don't mind if I ping you on this to get your thoughts. Not my PR but configuring power management would be nice for me now that I am considering retiring my old Mac to be headless. |
|
Any progress on this? |
Samasaur1
suggested changes
Oct 21, 2024
PhilipBorgesen
force-pushed
the
power-related-options
branch
2 times, most recently
from
2604d65 to
4c40a38
Compare
Enzime
requested changes
Oct 23, 2024
PhilipBorgesen
force-pushed
the
power-related-options
branch
from
4c40a38 to
4be0c9e
Compare
PhilipBorgesen
force-pushed
the
power-related-options
branch
from
4be0c9e to
f737259
Compare
|
Tests added |
Enzime
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, I've recently picked up nix-darwin to configure a Mac Mini M2 as a home server.
I need to configure some power related options that nix-darwin currently does not offer, so I would like to contribute them.
This pull request adds:
networking.wakeOnLan.enablepower.restartAfterPowerFailurepower.restartAfterFreezepower.sleep.computerpower.sleep.displaypower.sleep.harddiskpower.sleep.allowSleepByPowerButtonThe options are implemented by means of the
systemsetupcommand that also is used for thetime.timezoneoption.I believe this is the command that System Settings uses behind the screen.
I've tried to guess where it made most sense to add the new options.
I've added a new
powermodule; maybe it would make more sense to place the restartXXX and sleep options undersysteminstead. I'm prepared to move them elsewhere as per your feedback.Thanks for creating nix-darwin!