Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing pos interval map entry in pose estimation #1208

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Fix missing pos interval map entry in pose estimation #1208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10bd992
fix missing pos interval map entry in pose estimation
samuelbray32 Jan 7, 2025
c8f9962
update changelog
samuelbray32 Jan 7, 2025
ad9955f
strip extra key values in no_transaction_make
samuelbray32 Jan 15, 2025
2658773
Merge branch 'master' into 1207_fix
samuelbray32 Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
- Ensure merge tables are declared during file insertion #1205
- Update URL for DANDI Docs #1210

### Pipelines

- Position
- Allow population of missing `PositionIntervalMap` entries during population of `DLCPoseEstimation` #1208

## [0.5.4] (December 20, 2024)

### Infrastructure
Expand Down
3 changes: 3 additions & 0 deletions src/spyglass/common/common_behav.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,9 @@ def _no_transaction_make(self, key):
EPSILON = 0.51 # tolerated time diff in bounds across epoch/pos
no_pop_msg = "CANNOT POPULATE PositionIntervalMap"

# Strip extra info from key if not passed via populate call
key = {k: v for k, v in key.items() if k in self.primary_key}

nwb_file_name = key["nwb_file_name"]
pos_intervals = get_pos_interval_list_names(nwb_file_name)
null_key = dict(key, position_interval_name="")
Expand Down
1 change: 0 additions & 1 deletion src/spyglass/position/v1/position_dlc_pose_estimation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,6 @@ def _logged_make(self, key):
"nwb_file_name": key["nwb_file_name"],
"epoch": key["epoch"],
},
populate_missing=False,
)
)
if interval_list_name:
Expand Down
Loading