Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ptp option #69

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Disable ptp option #69

merged 2 commits into from
Nov 18, 2023

Conversation

samuelbray32
Copy link
Collaborator

Fixes #66

  • Implements disable_ptp parameter that overides the ptp flag in the rec header and sets ptp_enabled=False. Useful when ptp does not perform correctly at experiment time, but trodes timestamps are still functional.
  • Adds warning if PTP timestamps correspond to a date before 2000

@samuelbray32 samuelbray32 requested a review from edeno November 17, 2023 23:15
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bccfeb8) 90.62% compared to head (8c7447f) 90.55%.

Files Patch % Lines
src/trodes_to_nwb/convert.py 66.66% 1 Missing ⚠️
src/trodes_to_nwb/convert_position.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   90.62%   90.55%   -0.07%     
==========================================
  Files          25       25              
  Lines        2346     2351       +5     
==========================================
+ Hits         2126     2129       +3     
- Misses        220      222       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edeno edeno merged commit 5983072 into main Nov 18, 2023
7 of 10 checks passed
@edeno edeno deleted the disable_ptp branch November 18, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in PTP-enabled .cameraHWSync data file
2 participants