Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template after relicensing #4860

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update PR template after relicensing #4860

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73c6c06
update
RMeli Dec 22, 2024
d5fef31
improvements
RMeli Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
Fixes #
Fixes #<!-- Insert issue number that this PR fixes just after #-->

RMeli marked this conversation as resolved.
Show resolved Hide resolved
Changes made in this Pull Request:
-
- <!-- Describe the changes that this PR makes. -->

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove, the "Changes made in this Pull Request" is already pretty clear, isn't it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, yet people leave this bullet point empty most of the time... I was an attempt to clarify that they should fill it.


PR Checklist
------------
- [ ] Tests?
- [ ] Docs?
- [ ] Tests added?
- [ ] Documentation updated?
RMeli marked this conversation as resolved.
Show resolved Hide resolved
- [ ] CHANGELOG updated?
- [ ] Issue raised/referenced?

RMeli marked this conversation as resolved.
Show resolved Hide resolved
## Developers certificate of origin
- [ ] I certify that this contribution is covered by the LGPLv2.1+ license as defined in our [LICENSE](https://github.com/MDAnalysis/mdanalysis/blob/develop/LICENSE) and adheres to the [**Developer Certificate of Origin**](https://developercertificate.org/).
Loading