Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding light mode toggle #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Amitkumarkoli
Copy link
Contributor

Description

adding light and dark theme across screens with a icon button

Fixes #3

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [√ ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Other (please specify):

Checklist:

  • [ √] My code follows the style guidelines of this project
  • [√ ] I have performed a self-review of my own code
  • [ √] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Screenshots (if applicable)

Please include any relevant screenshots or images that help explain the changes made.

Additional Information

  • Name:
  • Email:
  • Roll No:
  • Branch:

Copy link
Member

@Bijayanee Bijayanee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Amitkumarkoli, some changes are required in your code.
Appbars need to be of same purple color that is used for other icons and buttons;
color of the texts, hint texts, text boxes in home page should also be changed with the theme;
remove the theme toggle button from home page, it will only be there in profile edit page.

@Amitkumarkoli
Copy link
Contributor Author

ok I'll do asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Light mode toggle
2 participants