Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add controllers into public_api for vessel search and port #4013

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lwih
Copy link
Collaborator

@lwih lwih commented Jan 8, 2025

Description

Ajouté dans public_api des controllers pour les Ports et les Vessel (just l'endpoint /search)


  • Tests E2E (Cypress)

@lwih lwih force-pushed the api-port-vessel branch from 247dffd to 90765fb Compare January 8, 2025 13:56
Copy link

sonarqubecloud bot commented Jan 8, 2025

@RestController
@RequestMapping("/api/v1/ports")
@Tag(name = "APIs for Ports")
class PortController(private val getActivePorts: GetActivePorts) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je crois qu'il faut renommer en PublicPortController pour qu'il n'y ait pas de clash de nom de classe

@RestController
@RequestMapping("/api/v1/vessels")
@Tag(name = "APIs for Vessels")
class VesselController(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, avec Public

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants