Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ulam front action #489

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix/ulam front action #489

wants to merge 5 commits into from

Conversation

xtiannyeto
Copy link
Collaborator

No description provided.

 - Remove unecessary files after refacto
 - Rename type to avoid confusion
 - Update timeline Dropdown to use a direct list and uncouple ulam and pam
 - Create a specific pam timeline hook to return only timeline needs
 - refactor pam components to use the new hook
 - new hook for timeline
 - action registry and header
Copy link

Coverage Report for frontend

Status Category Percentage Covered / Total
🟢 Lines 59.5% (🎯 40%) 2532 / 4255
🟢 Statements 58.66% (🎯 40%) 2633 / 4488
🟢 Functions 44.91% (🎯 40%) 610 / 1358
🟢 Branches 49.42% (🎯 40%) 1025 / 2074
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
frontend/src/v2/features/common/hooks/use-action-registry.tsx 50% 0% 0% 50% 101
frontend/src/v2/features/common/hooks/use-mission-timeline.tsx 20% 0% 0% 20% 18-33
frontend/src/v2/features/common/types/action-type.ts 100% 100% 100% 100%
frontend/src/v2/features/common/types/mission-types.ts 100% 100% 100% 100%
frontend/src/v2/features/mission-action/components/elements/mission-action-header-action.tsx 11.11% 0% 0% 12.5% 18-44
frontend/src/v2/features/mission-action/components/elements/mission-action-item-contact.tsx 50% 100% 0% 50% 9-10
frontend/src/v2/features/mission-action/components/elements/mission-action-item-control.tsx 20% 0% 0% 20% 13-19
frontend/src/v2/features/mission-action/components/layout/mission-action-header-title-wrapper.tsx 50% 0% 0% 50% 26-46
frontend/src/v2/features/mission-timeline/components/elements/mission-timeline-add-action.tsx 0% 0% 0% 0% 20-59
frontend/src/v2/features/mission-timeline/components/elements/mission-timeline-add-status.tsx 23.07% 0% 0% 25% 23-30, 34-59
frontend/src/v2/features/mission-timeline/components/layout/mission-timeline-Header-wrapper.tsx 50% 0% 0% 50% 21-35
frontend/src/v2/features/mission-timeline/components/layout/mission-timeline-dropdown-wrapper.tsx 19.04% 0% 0% 22.22% 7-14, 17-20, 25-28, 38-58
frontend/src/v2/features/mission-timeline/components/layout/mission-timeline-wrapper.tsx 8.33% 0% 0% 11.11% 28-50
frontend/src/v2/features/mission-timeline/hooks/use-timeline.tsx 0% 0% 0% 0% 51-141
frontend/src/v2/features/pam/components/element/mission-action-item-pam.tsx 8.33% 0% 0% 10% 17-33
frontend/src/v2/features/pam/components/element/mission-action-pam-body.tsx 50% 100% 0% 50% 14-21
frontend/src/v2/features/pam/components/element/mission-action-pam.tsx 33.33% 0% 0% 33.33% 15-32
frontend/src/v2/features/pam/components/element/mission-timeline-header-pam.tsx 16.66% 100% 0% 20% 11-20
frontend/src/v2/features/pam/components/element/mission-timeline-item-pam.tsx 12.5% 100% 0% 12.5% 16-39
frontend/src/v2/features/pam/hooks/use-pam-action-registry.tsx 25% 100% 0% 25% 19-21
frontend/src/v2/features/pam/hooks/use-pam-timeline-registry.tsx 40% 0% 0% 50% 146-147
frontend/src/v2/features/ulam/components/element/mission-action-item-ulam.tsx 8.33% 0% 0% 10% 17-33
frontend/src/v2/features/ulam/components/element/mission-action-ulam-body.tsx 50% 100% 0% 50% 14-21
frontend/src/v2/features/ulam/components/element/mission-action-ulam.tsx 33.33% 0% 0% 33.33% 15-32
frontend/src/v2/features/ulam/components/element/mission-timeline-header-ulam.tsx 16.66% 100% 0% 20% 11-20
frontend/src/v2/features/ulam/components/element/mission-timeline-item-ulam.tsx 12.5% 100% 0% 12.5% 16-39
frontend/src/v2/features/ulam/components/element/mission-list/mission-list-item-ulam.tsx 66.66% 33.33% 40% 66.66% 59-64, 75-76, 81, 101, 103, 170-212
frontend/src/v2/features/ulam/hooks/use-ulam-action-registry.tsx 25% 100% 0% 25% 13-15
frontend/src/v2/features/ulam/hooks/use-ulam-crew-for-mission-list.tsx 66.66% 16.66% 50% 66.66% 5
frontend/src/v2/features/ulam/hooks/use-ulam-home-unit-resources.tsx 90% 80% 100% 90% 25
frontend/src/v2/features/ulam/hooks/use-ulam-timeline-registry.tsx 40% 0% 0% 50% 170-171
frontend/src/v2/pages/mission-list-ulam-page.tsx 11.76% 0% 0% 11.76% 27-73
Generated in workflow #1529 for commit f09b51e by the Vitest Coverage Report Action

Copy link

Overall Project 49.23%

There is no coverage information present for the Files changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant