Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Node Generator Module for vllm Serving API Integration #1062

Merged
merged 11 commits into from
Jan 4, 2025

Conversation

korjsh
Copy link
Contributor

@korjsh korjsh commented Dec 18, 2024

Purpose of Development

  • When using the existing vllm module, each test requires model reinitialization, leading to significant test time overhead.
  • By enabling API-based connections, similar to the OpenAI module, model reinitialization time can be saved, improving testing efficiency.

Testing Instructions

  1. Start the vllm serving server:
    vllm serve Qwen/Qwen2.5-14B-Instruct-AWQ -q awq --port 8012
    
  2. Here is sample of evaluate_config.yaml file.
        - node_type: generator
          strategy:
             metrics: 
                 - metric_name: rouge
           modules:
                 - module_type: vllm_api
                   uri: http://localhost:8012
                   llm: Qwen/Qwen2.5-14B-Instruct-AWQ
                   temperature: [0, 0.5]
                   max_tokens: 400
  3. Execute the evaluation process.

@vkehfdl1
Copy link
Contributor

@korjsh Hello! Thanks for the contribution.
Before merging, we have to make a two more things.

  1. The test code. You should make a test code at the tests/autorag/nodes/generator
  2. The docs. You should make a new documentation at docs/source/nodes/generator

If you feel overwhelmed to make the test code and docs, we can cover it.
If you want the PR merge faster, it is always great to do it yourself.

Thanks a lot :)

Copy link
Contributor

@vkehfdl1 vkehfdl1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@vkehfdl1 vkehfdl1 enabled auto-merge (squash) January 4, 2025 07:56
@vkehfdl1 vkehfdl1 merged commit b4fa576 into Marker-Inc-Korea:main Jan 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants