Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

65 Plots are not displayed on the package web site #66

Merged
merged 7 commits into from
Dec 20, 2024

Conversation

fukuhiro2023
Copy link
Collaborator

This PR adds version control for reactR to fix a bug that plots are not displayed on a package web site.

@fukuhiro2023 fukuhiro2023 linked an issue Dec 19, 2024 that may be closed by this pull request
@wangben718 wangben718 requested a review from nanxstats December 20, 2024 02:56
@wangben718
Copy link
Collaborator

Use specific reactR version for pkgdown workflow

Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it's an achievement that you figured out the way to specify the reactR version in the pkgdown GHA workflow... that pak syntax is cryptic.

Although I think you still need to find a proper fix for the underlying problem, because everyone using the latest CRAN version of reactR (the default assumption) will have trouble rendering the plot. That can be a goal for 2025.

@nanxstats nanxstats merged commit bbb07e2 into main Dec 20, 2024
7 checks passed
@nanxstats nanxstats deleted the 65-plots-are-not-displayed-on-the-package-web-site branch December 20, 2024 05:20
@wangben718
Copy link
Collaborator

Nice, it's an achievement that you figured out the way to specify the reactR version in the pkgdown GHA workflow... that pak syntax is cryptic.

Although I think you still need to find a proper fix for the underlying problem, because everyone using the latest CRAN version of reactR (the default assumption) will have trouble rendering the plot. That can be a goal for 2025.

Do you think it is better to include the reactR version limitation into the DESCRIPTION file now? Or we need a thorough approach to resolve this issue.

@nanxstats
Copy link
Collaborator

Do you think it is better to include the reactR version limitation into the DESCRIPTION file now? Or we need a thorough approach to resolve this issue.

A proper fix is needed.

Any dependency version requirements in DESCRIPTION should be forward-looking, because the CRAN builds always run on the latest versions of packages on CRAN. So practically you can only use > or >=.

nanxstats added a commit that referenced this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plots are not displayed on the package web site
3 participants