Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: MMQA-188: remove mmi e2e tests from ci #29233

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

racitores
Copy link
Contributor

@racitores racitores commented Dec 16, 2024

Description

MMI e2e tests are not longer maintained so they need to be removed from ci:

  • Remove CI (only this in this PR due to the urgency of the change)

Create a new PR to remove the next points:

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@racitores racitores changed the title chore: remove mmi e2e tests from ci MMQA-188: remove mmi e2e tests from ci Dec 16, 2024
@chloeYue chloeYue changed the title MMQA-188: remove mmi e2e tests from ci test: MMQA-188: remove mmi e2e tests from ci Dec 16, 2024
@chloeYue chloeYue added e2e-test End to end test for the MetaMask extension team-mmi PRs from the MMI team team-qa QA team and removed team-mmi PRs from the MMI team labels Dec 16, 2024
chloeYue
chloeYue previously approved these changes Dec 16, 2024
Copy link
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd-ob
cmd-ob previously approved these changes Dec 16, 2024
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Publish MMI release to Sentry" step of the job-publish-release job also needs to be removed

@racitores racitores closed this Jan 15, 2025
@racitores racitores force-pushed the fix/remove-mmi-e2e-tests branch from ec592df to d8ce2c7 Compare January 15, 2025 08:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
@racitores racitores reopened this Jan 15, 2025
@racitores racitores dismissed stale reviews from cmd-ob and chloeYue via bd7b305 January 15, 2025 08:38
@racitores racitores marked this pull request as ready for review January 15, 2025 09:05
@racitores racitores requested a review from a team as a code owner January 15, 2025 09:05
@metamaskbot
Copy link
Collaborator

Builds ready [bd7b305]
Page Load Metrics (1578 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1379171915828943
domContentLoaded1367170615618943
load1381172815789043
domInteractive22134352512
backgroundConnect64716115
firstReactRender16100573015
getState567242311
initialActions00000
loadScripts1000129211637435
setupStore6431084
uiStartup155024651930260125
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

1 similar comment
@metamaskbot
Copy link
Collaborator

Builds ready [bd7b305]
Page Load Metrics (1578 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1379171915828943
domContentLoaded1367170615618943
load1381172815789043
domInteractive22134352512
backgroundConnect64716115
firstReactRender16100573015
getState567242311
initialActions00000
loadScripts1000129211637435
setupStore6431084
uiStartup155024651930260125
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [2344205]
Page Load Metrics (1780 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15692185179117081
domContentLoaded15182079175414771
load15672103178015374
domInteractive26185584019
backgroundConnect6104252311
firstReactRender15105452813
getState587252512
initialActions01000
loadScripts11121545131812459
setupStore687192311
uiStartup177030462113333160
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@dbrans dbrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
e2e-test End to end test for the MetaMask extension team-qa QA team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants