chore: remove `@metamask/eth-query` package #29649

cryptodev-2s · 2025-01-12T13:20:31Z

Description

This PR removes @metamask/eth-query package by using directly the provider without using any wrapper package.

The purpose of this PR is to simplify and break down the process of replacing web3-stream-provider (issue), which uses the legacy sendAsync method and is not EIP-1193 compliant, with StreamProvider from @metamask/providers, which fully adheres to the EIP-1193 Specs.

Related issues

Fixes: partially completes #28774

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-01-12T13:20:43Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cryptodev-2s · 2025-01-12T13:23:46Z

@metamaskbot update-policies

metamaskbot · 2025-01-12T13:34:31Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-01-12T14:10:21Z

Builds ready [6f611fc]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1476 ± 40 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1368	1667	1488	88	42
		domContentLoaded	1318	1655	1457	82	39
		load	1370	1668	1476	83	40
		domInteractive	20	58	35	13	6
		backgroundConnect	8	55	20	16	7
		firstReactRender	15	99	36	30	15
		getState	4	80	21	22	11
		initialActions	0	1	0	0	0
		loadScripts	967	1278	1078	74	36
		setupStore	6	9	7	1	0
		uiStartup	1546	2016	1774	155	74

cryptodev-2s · 2025-01-13T12:09:39Z

@metamaskbot update-policies

metamaskbot · 2025-01-13T12:20:30Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-01-13T12:56:38Z

Builds ready [f4d3e00]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1671 ± 65 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1473	1933	1674	132	63
		domContentLoaded	1422	1907	1648	135	65
		load	1476	1943	1671	135	65
		domInteractive	24	183	59	48	23
		backgroundConnect	9	58	22	14	7
		firstReactRender	15	71	36	22	10
		getState	4	59	24	21	10
		initialActions	0	1	0	0	0
		loadScripts	1037	1435	1220	114	55
		setupStore	6	40	11	8	4
		uiStartup	1706	2232	1899	144	69

metamaskbot · 2025-01-13T14:46:58Z

Builds ready [3acfcd6]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1579 ± 36 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1455	1766	1585	69	33
		domContentLoaded	1440	1708	1545	68	33
		load	1450	1768	1579	75	36
		domInteractive	22	64	34	13	6
		backgroundConnect	9	99	36	26	12
		firstReactRender	16	101	41	30	14
		getState	4	56	17	16	8
		initialActions	0	1	0	0	0
		loadScripts	1045	1321	1152	66	32
		setupStore	6	78	19	25	12
		uiStartup	1613	2286	1922	213	102

cryptodev-2s · 2025-01-14T18:52:16Z

@metamaskbot update-policies

metamaskbot · 2025-01-14T19:03:11Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-01-14T19:39:03Z

Builds ready [6d7441d]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1805 ± 92 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	339	2347	1734	379	182
		domContentLoaded	1533	2280	1773	191	92
		load	1563	2302	1805	191	92
		domInteractive	24	123	47	27	13
		backgroundConnect	12	111	27	23	11
		firstReactRender	16	101	49	33	16
		getState	5	90	32	28	14
		initialActions	0	1	0	0	0
		loadScripts	1137	1752	1319	157	76
		setupStore	6	64	16	19	9
		uiStartup	1700	2829	2191	297	143

Bundle size diffs [🚀 Bundle size reduced!]

background: -476 Bytes (-0.01%)
ui: -152 Bytes (-0.00%)
common: 197 Bytes (0.00%)

mcmire

Just one thing I noticed.

ui/ducks/swaps/swaps.js

mcmire

LGTM.

OGPoyraz

Confirmation changes LGTM

metamaskbot · 2025-01-15T12:51:16Z

Builds ready [658241b]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1687 ± 72 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1496	2124	1681	152	73
		domContentLoaded	1454	2048	1649	146	70
		load	1496	2137	1687	151	72
		domInteractive	24	78	36	15	7
		backgroundConnect	7	87	30	23	11
		firstReactRender	16	108	52	33	16
		getState	4	95	17	23	11
		initialActions	0	1	0	0	0
		loadScripts	1033	1583	1208	123	59
		setupStore	6	47	11	12	6
		uiStartup	1691	2939	2045	296	142

Bundle size diffs [🚀 Bundle size reduced!]

background: -476 Bytes (-0.01%)
ui: -152 Bytes (-0.00%)
common: 197 Bytes (0.00%)

cryptodev-2s added the team-wallet-framework label Jan 12, 2025

cryptodev-2s self-assigned this Jan 12, 2025

cryptodev-2s requested a review from a team as a code owner January 12, 2025 13:20

cryptodev-2s marked this pull request as draft January 12, 2025 13:20

cryptodev-2s changed the title ~~chore: remove @metemask/eth-query package~~ chore: remove @metamask/eth-query package Jan 12, 2025

cryptodev-2s marked this pull request as ready for review January 12, 2025 14:54

cryptodev-2s requested review from a team as code owners January 12, 2025 14:54

cryptodev-2s force-pushed the cryptodev2s/remove-ethsjs branch from f43efd9 to 6b3c256 Compare January 13, 2025 10:57

cryptodev-2s force-pushed the cryptodev2s/remove-eth-query-package branch from 6f611fc to 7066fe8 Compare January 13, 2025 12:09

cryptodev-2s requested a review from a team as a code owner January 13, 2025 14:09

Base automatically changed from cryptodev2s/remove-ethsjs to main January 14, 2025 17:46

chore: remove @metemask/eth-query package

0e2c767

cryptodev-2s force-pushed the cryptodev2s/remove-eth-query-package branch from 3acfcd6 to 0e2c767 Compare January 14, 2025 18:51

Update LavaMoat policies

6d7441d

mcmire reviewed Jan 14, 2025

View reviewed changes

ui/ducks/swaps/swaps.js Show resolved Hide resolved

mcmire approved these changes Jan 14, 2025

View reviewed changes

mikesposito approved these changes Jan 15, 2025

View reviewed changes

OGPoyraz approved these changes Jan 15, 2025

View reviewed changes

jclancy93 approved these changes Jan 15, 2025

View reviewed changes

cryptodev-2s added this pull request to the merge queue Jan 15, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025

cryptodev-2s added this pull request to the merge queue Jan 15, 2025

cryptodev-2s removed this pull request from the merge queue due to a manual request Jan 15, 2025

Merge branch 'main' into cryptodev2s/remove-eth-query-package

19ed471

cryptodev-2s enabled auto-merge January 15, 2025 11:55

Merge branch 'main' into cryptodev2s/remove-eth-query-package

658241b

cryptodev-2s added this pull request to the merge queue Jan 15, 2025

Merged via the queue into main with commit 3944d7e Jan 15, 2025
80 checks passed

cryptodev-2s deleted the cryptodev2s/remove-eth-query-package branch January 15, 2025 13:23

github-actions bot locked and limited conversation to collaborators Jan 15, 2025

metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove `@metamask/eth-query` package #29649

chore: remove `@metamask/eth-query` package #29649

cryptodev-2s commented Jan 12, 2025 •

edited

Loading

github-actions bot commented Jan 12, 2025

cryptodev-2s commented Jan 12, 2025

metamaskbot commented Jan 12, 2025

metamaskbot commented Jan 12, 2025

cryptodev-2s commented Jan 13, 2025

metamaskbot commented Jan 13, 2025

metamaskbot commented Jan 13, 2025

metamaskbot commented Jan 13, 2025

cryptodev-2s commented Jan 14, 2025

metamaskbot commented Jan 14, 2025

metamaskbot commented Jan 14, 2025

mcmire left a comment

mcmire left a comment

OGPoyraz left a comment

metamaskbot commented Jan 15, 2025

chore: remove @metamask/eth-query package #29649

chore: remove @metamask/eth-query package #29649

Conversation

cryptodev-2s commented Jan 12, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 12, 2025

cryptodev-2s commented Jan 12, 2025

metamaskbot commented Jan 12, 2025

metamaskbot commented Jan 12, 2025

cryptodev-2s commented Jan 13, 2025

metamaskbot commented Jan 13, 2025

metamaskbot commented Jan 13, 2025

metamaskbot commented Jan 13, 2025

cryptodev-2s commented Jan 14, 2025

metamaskbot commented Jan 14, 2025

metamaskbot commented Jan 14, 2025

mcmire left a comment

Choose a reason for hiding this comment

mcmire left a comment

Choose a reason for hiding this comment

OGPoyraz left a comment

Choose a reason for hiding this comment

metamaskbot commented Jan 15, 2025

chore: remove `@metamask/eth-query` package #29649

chore: remove `@metamask/eth-query` package #29649

cryptodev-2s commented Jan 12, 2025 •

edited

Loading