chore: Bump Snaps packages #29693
Draft
chore: Bump Snaps packages #29693
+1,148
−278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
## **Description** This PR adds the `hideBalances` property to `getPreferences` which binds to the `privacyMode` state property from the `PreferenceController`. [](https://codespaces.new/MetaMask/metamask-extension/pull/29626?quickstart=1) ## **Related issues** Progresses: MetaMask/snaps#2977 ## **Manual testing steps** ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** ### **After** ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? New background events feature. 2. What is the improvement/solution? Added code to integrate the new feature. ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** This PR allows the usage of the `Text` component in the Snap UI `Value` component props. [](https://codespaces.new/MetaMask/metamask-extension/pull/29624?quickstart=1) ## **Related issues** progresses: MetaMask/snaps#2984 ## **Manual testing steps** ```tsx <Box> <Row label="Amount"> <Value value={<Text color="success">1.555 ETH</Text>} extra={<Text color="error">2.44 $</Text>} /> </Row> </Box> ``` ## **Screenshots/Recordings**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
#29095) This PR adds `backgroundColor` property to Container component. Background colors that can be used are predefined as: default and alternative. This PR deliberately disables the `backgroundColor` feature for containers used within Transaction Insights pages (Snaps). [](https://codespaces.new/MetaMask/metamask-extension/pull/29095?quickstart=1) Fixes: MetaMask/snaps#2906 Related Snaps PR: MetaMask/snaps#2950 1. Try installing and using a Snap with confirmation window or home page, with `Container` in its content with `backgroundColor` defined (e.g. `<Container backgroundColor="default">`). 2. Try the same thing on transaction insights Snaps and confirm that the colors are not changing there. 3. Confirm that the colors are as expected on all pages. Some source code used for testing: - Source code used for confirmation content: ```typescript export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => { switch (request.method) { case 'hello': return snap.request({ method: 'snap_dialog', params: { content: ( <Container backgroundColor="default"> <Box> <Section> <Row label="From"> <Address address="0x1234567890123456789012345678901234567890" /> </Row> <Row label="To" variant="warning" tooltip="This address has been deemed dangerous." > <Address address="0x0000000000000000000000000000000000000000" /> </Row> </Section> <Form name="form"> <Box direction="horizontal"> <Field label="baz"> <Input name="baz" placeholder="Enter something..." /> </Field> <Field label="foo"> <Selector title="bar" name="test"> <SelectorOption value="one"> <Card title="test" value="test" /> </SelectorOption> </Selector> </Field> </Box> <Field label="something_else"> <Selector title="bar" name="test2"> <SelectorOption value="one"> <Card title="test" value="test" /> </SelectorOption> </Selector> </Field> <Box direction="horizontal"> <Field label="baz2"> <Input name="baz2" placeholder="Enter something..." /> </Field> <Field label="foo3"> <Input name="foo3" placeholder="Enter something..." /> </Field> </Box> <Box direction="horizontal"> <Field label="Example Dropdown"> <Dropdown name="example-dropdown"> <Option value="option1">Option 1</Option> <Option value="option2">Option 2</Option> <Option value="option3">Option 3</Option> </Dropdown> </Field> <Field label="Example RadioGroup"> <RadioGroup name="example-radiogroup"> <Radio value="option1">Option 1</Radio> <Radio value="option2">Option 2</Radio> <Radio value="option3">Option 3</Radio> </RadioGroup> </Field> </Box> <Field label="Example Dropdown full width"> <Dropdown name="example-dropdown-full"> <Option value="option1">Option 1</Option> <Option value="option2">Option 2</Option> <Option value="option3">Option 3</Option> </Dropdown> </Field> <Field label="Example RadioGroup full width"> <RadioGroup name="example-radiogroup-full"> <Radio value="option11">Option 11</Radio> <Radio value="option22">Option 22</Radio> <Radio value="option33">Option 33</Radio> </RadioGroup> </Field> <Field label="foo4"> <Input name="foo4" placeholder="Enter something..." /> </Field> <Box direction="horizontal"> <Field label="baz3"> <Input name="baz3" placeholder="Enter something..." /> </Field> </Box> <Box direction="horizontal"> <Field label="Example Checkbox"> <Checkbox name="example-checkbox" label="Checkbox" /> </Field> <Field label="Example Selector"> <Selector name="example-selector" title="Choose an option" value="option1" > <SelectorOption value="option1"> <Card title="Option 1" value="option1" /> </SelectorOption> <SelectorOption value="option2"> <Card title="Option 2" value="option2" /> </SelectorOption> <SelectorOption value="option3"> <Card title="Option 3" value="option3" /> </SelectorOption> </Selector> </Field> </Box> <Field label="Example FileInput 2"> <FileInput name="file-input-2" /> </Field> <Field label="Example Checkbox Full field"> <Checkbox name="example-checkbox-full" label="Checkbox" /> </Field> <Box direction="horizontal"> <Field label="baz4"> <Input name="baz4" placeholder="Enter something..." /> </Field> <Field label="Example FileInput"> <FileInput name="file-input-1" /> </Field> </Box> <Box direction="horizontal"> <Field label="baz5"> <Input name="baz5" placeholder="Enter something..." /> </Field> <Field label="FileInput Compact"> <FileInput name="file-input-3" compact={true} /> </Field> </Box> <Field label="FileInput Compact 2 full"> <FileInput name="file-input-4" compact={true} /> </Field> </Form> </Box> </Container> ), }, }); default: throw new Error('Method not found.'); } }; ``` Note: Changing container colors was not possible before.         - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
FrederikBolding
force-pushed
the
fb/snaps-bump-v82
branch
from
603bf8d to
898525b
Compare
](https://codespaces.new/MetaMask/metamask-extension/pull/29626?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/29624?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/29095?quickstart=1){kind=link}
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This adds support for new methods to manage state from Snaps: - `snap_getState` - `snap_setState` - `snap_clearState` These will eventually replace the `snap_manageState` method we have currently. [](https://codespaces.new/MetaMask/metamask-extension/pull/29016?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/29016?quickstart=1){kind=link}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump Snaps packages and handle any required changes.
Summary of Snaps changes:
snap_getState,snap_setState,snap_clearStateRPC methodssnap_scheduleBackgroundEventeth_signTypedDatahideBalancesproperty tosnap_getPreferencesTextinValuepropsbackgroundColorproperty toContainercomponentRelated issues
Closes MetaMask/snaps#2977
Closes MetaMask/snaps#2906
Closes #29498
Closes #29469