Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poc: dynamic switch network confirmation #29723

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Jan 15, 2025

Description

POC to verify an implementation for the following:

  • Remove QueuedRequestController and middleware.
  • Show switch network confirmation only if there are pending confirmations for the same origin.
  • Display origin in switch network confirmation.
  • Add pending confirmation alert to add network confirmation.
  • Add pending confirmation alert to permission confirmation.
  • Show toast if origin changed in confirmation within last minute.
  • Remove rejection of all pending approvals on network change.
  • Reject only pending approvals for site switching network.
  • Remove additional references to the global network to support navigation between confirmations on alternate chains.

No unit tests and example copy only given POC.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Switch Network Confirmation Add Network Confirmation Permission Confirmation Origin Change Toast

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Remove QueuedRequestController.
Add origin pill to switch network confirmation.
Add pending confirmations warning to add network confirmation.
Add pending confirmations warning to add permission confirmation.
Show toast if origin changed.
Clear only confirmations for origin when switching network.
Fix origin change in toast.
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants