-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multichain API E2E Test: handling when MetaMask is password locked #29724
Open
ffmcgee725
wants to merge
10
commits into
jl/caip-multichain-migrate-core
Choose a base branch
from
jc/password-locked-test-dapp-e2e
base: jl/caip-multichain-migrate-core
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Multichain API E2E Test: handling when MetaMask is password locked #29724
ffmcgee725
wants to merge
10
commits into
jl/caip-multichain-migrate-core
from
jc/password-locked-test-dapp-e2e
+189
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffmcgee725
commented
Jan 15, 2025
ffmcgee725
commented
Jan 15, 2025
ffmcgee725
commented
Jan 15, 2025
Builds ready [4a36b78]
Page Load Metrics (1726 ± 83 ms)
|
adonesky1
reviewed
Jan 15, 2025
adonesky1
reviewed
Jan 15, 2025
adonesky1
reviewed
Jan 15, 2025
adonesky1
reviewed
Jan 15, 2025
adonesky1
reviewed
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- test: multichain test dapp e2e tests for password locked extension;
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist