Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reveal srp to hd accounts. #29726

Open
wants to merge 3 commits into
base: multi-srp-mvp
Choose a base branch
from

Conversation

montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Jan 15, 2025

Description

This PR address a reveal srp button to HD accounts.

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/jira/software/projects/MMMULTISRP/boards/721?selectedIssue=MMMULTISRP-21

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Jan 15, 2025

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 0 B
npm/@metamask/[email protected] None 0 60.9 kB metamaskbot
npm/@metamask/[email protected] None +1 769 kB metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None +1 293 kB metamaskbot

View full report↗︎

@montelaidev montelaidev marked this pull request as ready for review January 16, 2025 06:33
@montelaidev montelaidev requested a review from a team as a code owner January 16, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants