Skip to content

Commit

Permalink
Update minimum Node.js version to v16 (#225)
Browse files Browse the repository at this point in the history
The minimum Node.js version has been updated to v16. This is the only
version tested in CI because there is a known incompatibility with v18
that we will address in a later PR.

This fixes build issues encountered on systems with Python v3.11
installed.
  • Loading branch information
Gudahtt authored Apr 24, 2023
1 parent 6be7092 commit 334a564
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-lint-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
node-version: [14.x, 16.x]
node-version: [16.x]
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v14
v16
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ static-server node_modules/@metamask/test-dapp/dist --port 9011

### Setup

- Install [Node.js](https://nodejs.org) version 14
- Install [Node.js](https://nodejs.org) version 16
- If you are using [nvm](https://github.com/creationix/nvm#installation) (recommended) running `nvm use` will automatically choose the right node version for you.
- Install [Yarn v1](https://yarnpkg.com/en/docs/install)
- Run `yarn setup` to install dependencies and run any required post-install scripts
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "5.7.0",
"description": "A simple dapp used in MetaMask e2e tests.",
"engines": {
"node": ">= 14.0.0"
"node": ">= 16.0.0"
},
"scripts": {
"setup": "yarn install && yarn allow-scripts",
Expand Down

0 comments on commit 334a564

Please sign in to comment.