Added missing ObjectManipulator components to scene descriptions #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenediktTobias
requested review from
marlenaklein-msft,
AMollis,
shaynie and
a team
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@ghazen-ml, please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #679, fixes #683, fixes #686, fixes #687, fixes #688. fixes #689
Updated the host transform reference of the ObjectManipulator component in the AudioOcclusion scene to move the entire scene instead of just the scene description.
Added missing ObjectManipulator, MinMaxScaleConstraint and BoxCollider components to the AudioLoFi, Dialog, NonCanvasDialog, SpatialMapping and ToggleCollection example scenes and configured them accordingly to ensure the expected behaviour.