Skip to content

Commit

Permalink
Merge pull request #98 from askoriy/fix/more-ignored-configs
Browse files Browse the repository at this point in the history
  • Loading branch information
Mongey authored Aug 12, 2021
2 parents 65741b0 + e4b82f2 commit f0f313a
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions ccloud/resource_connector.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ func ignoreConnectorConfigs() []string {
"config.cloud.provider",
"config.cloud.environment",
"config.valid.kafka.api.key",
"config.schema.registry.url",
}
}

Expand Down Expand Up @@ -73,9 +74,9 @@ func connectorResource() *schema.Resource {
return true
}

// Kafka API key and secret pose a problem. What if they REALLY have changed? No way to detect here.
// Sensitive data are not returned from status query, so changes made to it outside of terraform could not be tracked
masked, _ := regexp.MatchString("\\*+", old)
if (k == "config.kafka.api.key" || k == "config.kafka.api.secret") && masked {
if masked {
return true
}

Expand Down

0 comments on commit f0f313a

Please sign in to comment.