RCS fuel flow fixes and missing last stage in the VAB #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the ALL_VESSEL checks, it needs to be looking at "PartsRemainingInStage" rather than Vessel.Parts since the latter isn't updated as the Sim runs. This also affects ModuleEngines as well, but typically engines don't use ALL_VESSEL flow, so it seems like it affects RCS. This also should fix bugs with the bottom stage being missing in the VAB. Signed-off-by: Lamont Granquist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ALL_VESSEL checks, it needs to be looking at "PartsRemainingInStage" rather than Vessel.Parts since the latter isn't updated as the Sim runs.
This also affects ModuleEngines as well, but typically engines don't use ALL_VESSEL flow, so it seems like it only practically affects RCS.
This also should fix bugs with the bottom stage being missing in the VAB.
closes #1919