Do not format helm yaml templates #2439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
artntek
requested changes
Jul 2, 2024
| **/*.min.* | ||
| # Ignore helm's go yaml templates | ||
| helm/**/*.yaml |
There was a problem hiding this comment.
I think for now, we could safely just make this everything in helm/, not just *.yaml files. For example, there are _*.tpl files, *.js files, soon to be *.sh files, all of which are go templates.
|
Closing this PR. Instead, @robyngit and I agreed that I shoudl make this change in PR #2427 (see change here) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prettier misinterprets go templating in yaml as invalid yaml syntax. Unfortunately, there is not currently support for Helm’s template + yaml language, so this PR makes sure Prettier ignore these files. It also updates the helm branch with the latest develop changes, so that Prettier is available to update!