Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all required parameters to ssl-proxy config in README.md. #645

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

aacic
Copy link
Collaborator

@aacic aacic commented Jul 19, 2023

As explained here:

cameronhunter/local-ssl-proxy#113

local-ssl-proxy config should look like this:

"Host": {
        "source": 8080,
        "target": 8081,
        "key": "localhost-key.pem",
        "cert": "localhost.pem",
        "hostname": "localhost"
    }

Description

Checklist

  • Added proper unit tests
  • Left proper TODO messages for any remaining tasks
  • Scanned for web accessibility with aXe, and mitigated or documented
    flagged issues

Screenshots/Screen Recordings (if Appropriate)

@aacic aacic requested review from siosonel and craigrbarnes and removed request for siosonel July 19, 2023 19:50
@aacic aacic changed the title Add all required parameters, including key and cert params to local-s… Add all required parameters to ssl-proxy config in README.md. Jul 19, 2023
@aacic aacic requested a review from siosonel July 19, 2023 20:19
@craigrbarnes craigrbarnes merged commit fac300b into develop Jul 20, 2023
@craigrbarnes craigrbarnes deleted the update-readme-local-ssl-proxy-config branch July 20, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants