Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gdcmvs #284

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Gdcmvs #284

wants to merge 9 commits into from

Conversation

msfitzsimons
Copy link
Contributor

No description provided.

anncatton
anncatton reviewed Oct 22, 2018
View reviewed changes
Copy link
Contributor

@anncatton anncatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, am I right in thinking config.extra.gdcmvs_app_root will link to the gdcmvs folder? Is it possible for some of these scripts to come from cdn?

anncatton
anncatton previously approved these changes Oct 22, 2018
View reviewed changes
Copy link
Contributor

@anncatton anncatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard my first comment, looks like this is how the rest of the code is structured

@anncatton anncatton dismissed their stale review October 23, 2018 00:27

incomplete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anncatton anncatton anncatton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msfitzsimons @anncatton @fmanuelos