Require single class zonefiles by default, and give context if possible on parsing errors. #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection 5.2 requirement that a zonefile consist of exactly one class, enabled by default, and extend its error reporting to say what the wrong and expected classes were (and also use this contextual error support for other errors where applicable).
ximon18
added
enhancement
…uses some existing tests to fail.
bal-e
approved these changes
Jan 10, 2025
Comment on lines
+1589
to
+1601
| #[cfg(not(feature = "std"))] | ||
| { | ||
| f.write_str(self.msg) | ||
| } | ||
|
|
||
| #[cfg(feature = "std")] | ||
| { | ||
| if let Some(context) = &self.context { | ||
| f.write_fmt(format_args!("{}: {}", self.msg, context)) | ||
| } else { | ||
| f.write_str(self.msg) | ||
| } | ||
| } |
There was a problem hiding this comment.
It could be more concise if you write out the message unconditionally:
f.write_str(self.msg)?;
#[cfg(feature = "std")]
if let Some(context) = &self.context {
write!(f, ": {}", context)?;
}
|
|
||
| (None, Some(last_class)) => last_class, | ||
|
|
||
| (None, None) => { |
There was a problem hiding this comment.
I think this is not correct. There is no default class according to RFC 1035. Do other parsers accept leaving out the class entirely?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the inplace zone parser to detect violations of the RFC 1035 section 5.2 requirement that a zonefile consist of exactly one class, enabled by default, and extend its error reporting to say what the wrong and expected classes were (and also use this contextual error support for other errors where applicable).
This is a breaking change as it enables the validation checks by default.