Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State "old-serial" for nsd-control #420

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wtoorop
Copy link
Member

@wtoorop wtoorop commented Jan 7, 2025

As requested in Issue #419
"old-serial" is printed as state with nsd-control when the served serial is older than the one received by transfer. Also, state "future-serial" is printed if the served serial is newer than the one received by transfer.

As requested in Issue #419
"old-serial" is printed as state with nsd-control when the served serial is older than the one received by transfer.
Also, state "future-serial" is printed if the served serial is newer than the one received by transfer.
@pettai
Copy link

pettai commented Jan 8, 2025

It worked for us 👍 , I've added this patch to our own build

@wtoorop
Copy link
Member Author

wtoorop commented Jan 8, 2025

It worked for us 👍 , I've added this patch to our own build

Ah! That's good to know! I guess it's ready for review from Wouter and Jannik then :)

Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this output helps debugging. The code looks good to have.

@pettai
Copy link

pettai commented Jan 9, 2025

Not sure if the future-serial state is possible, though.
Seems NSD ignores notifies or transfers of older serials prematurely

Jan  9 10:05:34 sunic nsd[2978647]: xfrd: zone example.net ignoring old serial (2025010900/2024123101) from 130.242.125.XXX

And the state becomes refreshing. I've also tried to update serial on disk to a higher and lower value, but that doesn't seem to have any effect either. Perhaps a huge zone is needed for this to be noticed...

@pettai
Copy link

pettai commented Jan 13, 2025

Apparently, the catz zone can also end up in a non-ok state, yet reported as state: ok (ref #419 (comment))
Perhaps that could be fixed too before this pull request gets merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants