Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct F3 and g1 in NC at NNLO and N3LO #278

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Correct F3 and g1 in NC at NNLO and N3LO #278

merged 5 commits into from
Apr 23, 2024

Conversation

giacomomagni
Copy link
Collaborator

@giacomomagni giacomomagni commented Apr 17, 2024

We were using the wrong combination of CC coefficients to implement the non singlet NC F3 at NNLO and N3LO.
This might explain why Fig3 of the Yadism paper was much worst than the other benchmarks and might have an impact on the polarized g1

TODO:

  • Check the impact on g1 (FONLL polarized paper)
  • Check the benchmark with Apfel++ g1 (Yadism paper Fig3) @giacomomagni
  • Check impact on some FKtables
  • Check the impact on the IC valence paper, F3 plot. @giacomomagni

@felixhekhorn @Radonirinaunimi @RoyStegeman

@felixhekhorn felixhekhorn added the bug Something isn't working label Apr 17, 2024
@Radonirinaunimi
Copy link
Member

Thanks for this @giacomomagni! I can help checking the 1st and 2nd point.

@felixhekhorn felixhekhorn linked an issue Apr 17, 2024 that may be closed by this pull request
@giacomomagni
Copy link
Collaborator Author

giacomomagni commented Apr 17, 2024

Thanks for this @giacomomagni! I can help checking the 1st and 2nd point.

I'm taking care of point 2.

@Radonirinaunimi
Copy link
Member

Thanks for this @giacomomagni! I can help checking the 1st and 2nd point.

I'm taking care of point 2.

Ok, I will only take care of 1 then.

@giacomomagni
Copy link
Collaborator Author

I couldn't spot any major difference. If you agree we can proceed to merge.

Copy link
Member

@Radonirinaunimi Radonirinaunimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just compared the results with the pineappl grids used for the FONLL POL paper (although for ZM only) and the differences are numerical. So this indeed do not significant changes.

src/yadism/coefficient_functions/light/__init__.py Outdated Show resolved Hide resolved
src/yadism/coefficient_functions/light/f3_cc.py Outdated Show resolved Hide resolved
@giacomomagni giacomomagni merged commit 4059f59 into master Apr 23, 2024
5 checks passed
@giacomomagni giacomomagni deleted the fix_nc_f3 branch April 23, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Massless NC N3LO flavor decomposition is wrong
3 participants