Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have a consistent treatment of the integration error we should have only one integral per kinematic point, producing directly the whole result on its own.
Alternatives
There are two alternatives that make sense:
Second alternative
The second looks good because the result is fully provided by
scipy.integrate.quad
method, that in this way is able to deal properly with the error.Pro - Integration error
In this way it makes meaningful to call it setting a target error, otherwise keeping anything apart (as the addend that are a main contribution to the result) will make useless to set a relative error.
Note: maybe we can use the same an absolute error, since addends are not providing any integration error to the result
Contra - Domain measure
In order to join also the addends they should be divided by the domain measure, that it is a small number in large x region.
Report of run against APFEL with setup 2.