Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate info on initial states and polarized key #289

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Deprecate info on initial states and polarized key #289

merged 6 commits into from
Jul 3, 2024

Conversation

Radonirinaunimi
Copy link
Member

From v0.7.4, the initial_state_ keys in pineappl is deprecated. This release also introduced the convolution_type_ that specifies the type of convolution required by the initial state making the polarized key deprecated.

@Radonirinaunimi Radonirinaunimi added enhancement New feature or request physics physics features labels Jun 16, 2024
@giacomomagni giacomomagni linked an issue Jun 17, 2024 that may be closed by this pull request
Remove polarized key in grids as deprecated #286
Closed
@giacomomagni
Copy link
Collaborator

Need to change also convolute_with_one with convolve_with_one, there are two occurrences in the docs.

@Radonirinaunimi
Copy link
Member Author

Radonirinaunimi commented Jun 17, 2024 •
edited
Loading

Need to change also convolute_with_one with convolve_with_one, there are two occurrences in the docs.

That's right, thanks! Addressed in 2fb8790.

felixhekhorn
felixhekhorn approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@felixhekhorn felixhekhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! (I wished we had as many tests as in eko 😇 )

@Radonirinaunimi
Copy link
Member Author

Looks good to me! (I wished we had as many tests as in eko 😇 )

Indeed! I guess this is still one of the predicaments of Yadism.

@Radonirinaunimi
Copy link
Member Author

Actually, while checking that everything works fine until the generation of FK tables I realized that convolve_with_one although already merged in master is not part of v0.7.4, so I undid the changes.

I will write a test that at least checks this before merging!

@Radonirinaunimi Radonirinaunimi self-assigned this Jun 19, 2024
@giacomomagni giacomomagni mentioned this pull request Jun 25, 2024
Closed
3 tasks
@Radonirinaunimi
Copy link
Member Author

I changed my mind though. The test I was thinking of should not belong into yadism so I'd merge this as it is.

@giacomomagni giacomomagni merged commit 181b28b into master Jul 3, 2024
9 checks passed
@giacomomagni giacomomagni deleted the deprecated-polarized branch July 3, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giacomomagni giacomomagni giacomomagni approved these changes

@felixhekhorn felixhekhorn felixhekhorn approved these changes

Assignees

@Radonirinaunimi Radonirinaunimi

Labels
enhancement New feature or request physics physics features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove polarized key in grids as deprecated
3 participants
@Radonirinaunimi @giacomomagni @felixhekhorn