replace NaNs in output with 0 #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The moment you fix black, I think this is good to go |
|
after merging, I guess we should make a tag to make @scarlehoff happy - see NNPDF/pinefarm#87 it will be a minor - see v0.13.4...master |
RoyStegeman
force-pushed
the
replace_nans
branch
from
35d0747 to
a5d9b27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To produce the fiatulux grids we use points at small-x (x=1e-6), where LeProHQ may return NaNs. @niclaurenti used a separate branch to produce these grids, but I believe we should be able to use master going forward so I implement the function here.